DJ Delorie <[EMAIL PROTECTED]> writes: > It sounds like we're not communicating properly. The total patch set > to support core vs vliw modes, the part that needs to manage inlined > functions by attribute, is a total of four lines of code in the core > (not including prototypes). The two hooks are: > > > /* Return true if function CALLER cannot call CALLEE. Report an > error if so. CALLER is a decl and CALLEE is an arbitrary > function expression. */ > bool (* disallow_call_p) (tree caller, tree callee); > > /* Return true if function CALLER cannot inline calls to CALLEE. > Both arguments are decls. */ > bool (* disallow_inlining_p) (tree caller, tree callee); > > > and their calls: > > if (targetm.disallow_inlining_p (node->decl, decl)) > return false; > > if (targetm.disallow_call_p (current_function_decl, function)) > return error_mark_node;
I don't see a real problem with this, but I would prefer to see "allow_XX" rather than "disallow_XX". It's easier to understand code which is expressed in the positive. Ian
