On Fri, 10 May 2013, Zvi Gilboa wrote: > On the _/contribute/.html_//page (http://gcc.gnu.org/contribute.html), the > link to the script that should help check conformance with GNU coding style is > broken (the root "trunk" is unknown, etc.)
Thanks for the report, Zvi. I fixed this by means of the patch below. > More on that note: the first paragraph reads: "We strongly encourage > individuals as well as organizations to contribute...," yet it does not say > /why/ the GCC encourages that, or what the overall benefits (to society, the > contributing individual, etc.) would be. The navigation of http://gcc.gnu.org actually has a link to http://gcc.gnu.org/contributewhy.html . If you have a good suggestion where to add that on the contribute.html page, I will have a look. > Last but not least: in that first sentence, there should be /_no comma/_ > after GCC. And there should probably /_be_/ a comma before "as well > as," although that would be a matter of a judgment call, rather than a > strict grammatical rule. I remove the comma. Perhaps we had something like "be it" there originally, or it was just a rhetoric pause. Index: contribute.html =================================================================== RCS file: /cvs/gcc/wwwdocs/htdocs/contribute.html,v retrieving revision 1.82 diff -u -3 -p -r1.82 contribute.html --- contribute.html 3 Dec 2013 01:04:41 -0000 1.82 +++ contribute.html 3 Dec 2013 01:17:49 -0000 @@ -10,7 +10,7 @@ <h1>Contributing to GCC</h1> <p>We strongly encourage individuals as well as organizations to -contribute to the development of GCC, in the form of new features, new +contribute to the development of GCC in the form of new features, new or improved optimizations, bug fixes, documentation updates, web page improvements, etc....</p> @@ -69,7 +69,7 @@ well as requirements on code formatting. <p>Submissions which do not conform to the standards will be returned with a request to address any such problems. To help with the preparation of patches respecting these rules, one can use the script -<a href="http://gcc.gnu.org/viewcvs/trunk/contrib/check_GNU_style.sh";> +<a href="http://gcc.gnu.org/viewcvs/gcc/trunk/contrib/check_GNU_style.sh";> contrib/check_GNU_style.sh</a> to detect some of the common mistakes. </p>
