On Fri, Oct 10, 2014 at 04:50:47PM +0200, Christophe Lyon wrote: > On 10 October 2014 16:19, Jakub Jelinek <ja...@redhat.com> wrote: > > On Fri, Oct 10, 2014 at 04:09:39PM +0200, Christophe Lyon wrote: > >> my.exp contains the following construct which is often used in the > >> testsuite: > >> ========== > >> foreach src [lsort [glob -nocomplain $srcdir/$subdir/*.c]] { > >> # If we're only testing specific files and this isn't one of them, > >> skip it. > >> if ![runtest_file_p $runtests $src] then { > >> continue > >> } > >> c-torture-execute $src $additional_flags > >> gcc-dg-runtest $src "" $additional_flags > >> } > >> ========== > >> Note that gcc-dg-runtest calls runtest_file_p too. > > > > Such my.exp is invalid, you need to guarantee gcc_parallel_test_run_p > > is run the same number of times in all instances unless > > gcc_parallel_test_enable has been disabled. > > Thanks for your prompt answer. > > Is this documented somewhere, so that such cases do not happen in the future?
Feel free to submit a documentation patch. > It's in a patch which has been under review for quite some time > (started before your change), that's why you missed it. Ah, ok. > What about my remark about: > > # For parallelized check-% targets, this decides whether parallelization > > # is desirable (if -jN is used and RUNTESTFLAGS doesn't contain anything > > # but optional --target_board or --extra_opts arguments). If desirable, > I think it should be removed from gcc/Makefile.in Only the " and RUNTESTFLAGS ... arguments" part of that. Patch preapproved. Jakub