and this time with the patch ;-)

Cheers
Lex

2009/8/27 Lex Trotman <ele...@gmail.com>:
> 2009/8/27 Nick Treleaven <nick.trelea...@btinternet.com>:
>> On Tue, 25 Aug 2009 14:35:54 +1000
>> Lex Trotman <ele...@gmail.com> wrote:
>>
>>> This is a significant change which provides considerable flexibility
>>> for configuring the operation of the build menu.  Please read the
>>> manual for the new capabilities ;-) including hidden settings.
>> ...
>>> Let us know of any other problems, or good things too of course :-)
>>
>> I've been using the new build code today, I like the extra
>> configurability, thanks Lex (and Thomas) :)
>>
>> I noticed some things though:
>>
>> 1. Make keybindings don't work properly. The Make All keybinding seems
>> to run the Compile command (e.g. for C source files). The Make Object
>> keybinding doesn't do anything at all.
>
> Patch for keybindings.c attached
>
>>
>> 2. I think the current working directory should be used by default for
>> Make Object, not the project directory - presumably that doesn't work
>> even for a non-recursive makefile as the relative path isn't there. (I
>> mean for source files in a subdirectory from the project base path).
>> This would preserve pre-merge behaviour.
>
> Fixed in SVN & for make custom for which the same argument holds.
>
>>
>> 3. My Compile keybinding is set to F8, but the menu accelerator doesn't
>> seem to get set. The other build KB accels seem to be there OK.
>>
>
> fixed in SVN
>
>> Regards,
>> Nick
>> _______________________________________________
>> Geany-devel mailing list
>> Geany-devel@uvena.de
>> http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
>>
>
Index: src/keybindings.c
===================================================================
--- src/keybindings.c	(revision 4130)
+++ src/keybindings.c	(working copy)
@@ -1423,13 +1423,13 @@
 			item = menu_items->menu_item[GEANY_GBG_FT][GBO_TO_CMD(GEANY_GBO_BUILD)];
 			break;
 		case GEANY_KEYS_BUILD_MAKE:
-			item = menu_items->menu_item[GEANY_GBG_FT][GBO_TO_CMD(GEANY_GBO_MAKE_ALL)];
+			item = menu_items->menu_item[GEANY_GBG_NON_FT][GBO_TO_CMD(GEANY_GBO_MAKE_ALL)];
 			break;
 		case GEANY_KEYS_BUILD_MAKEOWNTARGET:
-			item = menu_items->menu_item[GEANY_GBG_FT][GBO_TO_CMD(GEANY_GBO_CUSTOM)];
+			item = menu_items->menu_item[GEANY_GBG_NON_FT][GBO_TO_CMD(GEANY_GBO_CUSTOM)];
 			break;
 		case GEANY_KEYS_BUILD_MAKEOBJECT:
-			item = menu_items->menu_item[GEANY_GBG_FT][GBO_TO_CMD(GEANY_GBO_MAKE_OBJECT)];
+			item = menu_items->menu_item[GEANY_GBG_NON_FT][GBO_TO_CMD(GEANY_GBO_MAKE_OBJECT)];
 			break;
 		case GEANY_KEYS_BUILD_NEXTERROR:
 			item = menu_items->menu_item[GBG_FIXED][GBF_NEXT_ERROR];
_______________________________________________
Geany-devel mailing list
Geany-devel@uvena.de
http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel

Reply via email to