[Geany-devel] [Patch] invalid memory read in vString tagamanger module

[Colomban Wendling]

Hi,

vStringStripTrailing() reads outside its buffer when called on an empty
vString [1]. Joined a trivial patch that fixes the problem.

Regards,
Colomban

[1] seen when parsing a .conf file

Index: tagmanager/vstring.c
===================================================================
--- tagmanager/vstring.c	(révision 4862)
+++ tagmanager/vstring.c	(copie de travail)
@@ -171,8 +171,8 @@
  */
 extern void vStringStripTrailing (vString *const string)
 {
-    while (isspace ((int) string->buffer [string->length - 1]) &&
-	   string->length > 0)
+    while (string->length > 0 &&
+	   isspace ((int) string->buffer [string->length - 1]))
     {
 	string->length--;
 	string->buffer [string->length] = '\0';

_______________________________________________
Geany-devel mailing list
Geany-devel@uvena.de
http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel