On Wed, 9 Jun 2010 15:10:22 +0200 Jiří Techet <tec...@gmail.com> wrote:
> > BTW, why do you destroy the dialog instead of hiding it? > > It's just that I can write > > if (switch_dialog) > > instead of > > if (switch_dialog && GTK_WIDGET_VISIBLE(switch_dialog)) > > but I can change that if your preference is different. When I wrote the code I assumed it would be faster to keep the dialog than reconstruct it each time, but I didn't do any benchmarking. Another general issue is that doing more than one change in a 'patch' makes it harder to review. Regards, Nick _______________________________________________ Geany-devel mailing list Geany-devel@uvena.de http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
