On 03/16/11 10:51, Nick Treleaven wrote:
On Wed, 16 Mar 2011 10:43:08 -0700 My comments: Changing 'Foo Bar:' to 'Foo bar:' in labels is good.
Fixed in the attached patch (see below).
Increasing horizontal separation between radio buttons - not sure, but perhaps more usable. Unaligning entry fields seems bad. Removing filetype from dialog title (even though each dialog has different fields) seems bad. Increasing vertical separations seems bad (out of keeping with Geany etc).
Sorry for the unfortunate filenames I chose, I should have said the left side is New the right side is Old (reverse of what the filenames imply).
I didn't look at the code BTW, only the screenshots. Also, if there are Gnome HIG reasons to support you, fair enough, but consistency with Geany is probably most important.
Cheers, Matthew Brush
>From ceb4abd0276500306f6a517695d03f9aed9bd9cf Mon Sep 17 00:00:00 2001 From: Matthew Brush <[email protected]> Date: Wed, 16 Mar 2011 11:06:18 -0700 Subject: [PATCH 4/4] Fix label capitalization as per GNOME HIG and Geany standards. --- plugins/classbuilder.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/plugins/classbuilder.c b/plugins/classbuilder.c index 843a41f..a56f65b 100644 --- a/plugins/classbuilder.c +++ b/plugins/classbuilder.c @@ -495,13 +495,13 @@ void show_dialog_create_class(gint type) G_CALLBACK(cc_dlg_on_class_name_entry_changed), cc_dlg); if (type != GEANY_CLASS_TYPE_PHP) - cc_dlg->header_entry = cc_table_attach_option_entry(table, _("Header File"), row++); + cc_dlg->header_entry = cc_table_attach_option_entry(table, _("Header file"), row++); - cc_dlg->source_entry = cc_table_attach_option_entry(table, _("Source File"), row++); + cc_dlg->source_entry = cc_table_attach_option_entry(table, _("Source file"), row++); cc_table_attach_section_label(table, _("Inheritance"), row++, TRUE); - cc_dlg->base_name_entry = cc_table_attach_option_entry(table, _("Base Class"), row++); + cc_dlg->base_name_entry = cc_table_attach_option_entry(table, _("Base class"), row++); if (type == GEANY_CLASS_TYPE_GTK) gtk_entry_set_text(GTK_ENTRY(cc_dlg->base_name_entry), "GObject"); @@ -509,12 +509,12 @@ void show_dialog_create_class(gint type) G_CALLBACK(cc_dlg_on_base_name_entry_changed), (gpointer)cc_dlg); if (type == GEANY_CLASS_TYPE_PHP) - cc_dlg->base_header_entry = cc_table_attach_option_entry(table, _("Base Source"), row++); + cc_dlg->base_header_entry = cc_table_attach_option_entry(table, _("Base source"), row++); else { hdr_hbox = gtk_hbox_new(FALSE, 6); - label = cc_table_attach_option_label(table, _("Base Header"), row); + label = cc_table_attach_option_label(table, _("Base header"), row); cc_dlg->base_header_entry = gtk_entry_new(); g_object_set_data(G_OBJECT(cc_dlg->base_header_entry), "label", label); -- 1.7.1
_______________________________________________ Geany-devel mailing list [email protected] http://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
