On Tue, 5 Apr 2011 17:19:29 +0100
Nick Treleaven <[email protected]> wrote:

> On Sun, 6 Mar 2011 15:53:48 +0100
> Enrico Tröger <[email protected]> wrote:
> 
> > >Note that when you check "regular expressions", Geany remembers the
> > >"case sensitive" state, [...]
> > 
> The idea was that most regex searches are case-sensitive so it would
> save time auto-enabling case-sensitive.
> 
> Now that the options are saved & restored I've removed this behaviour,
> as it can be confusing and/or annoying.

The last message (from 2011-03-09) from the "save find settings" thread
includes a patch that implements this behaviour accross restarts, but I
really prefer it removed altogether. So here is a few lines patch that
deletes the now useless comment about the stash prefs order, and moves
case prefs after regex, as it should be. Case closed. :)

-- 
E-gards: Jimmy
--- ./src/search.c.orig	2011-04-05 19:51:03.000000000 +0300
+++ ./src/search.c	2011-04-05 20:00:24.000000000 +0300
@@ -221,11 +221,10 @@
 	group = stash_group_new("search");
 	find_prefs = group;
 	configuration_add_pref_group(group, FALSE);
-	/* if case is moved after regexp, the first regexp uncheck will clear it */
-	stash_group_add_toggle_button(group, &settings.find_case_sensitive,
-		"find_case_sensitive", FALSE, "check_case");
 	stash_group_add_toggle_button(group, &settings.find_regexp,
 		"find_regexp", FALSE, "check_regexp");
+	stash_group_add_toggle_button(group, &settings.find_case_sensitive,
+		"find_case_sensitive", FALSE, "check_case");
 	stash_group_add_toggle_button(group, &settings.find_escape_sequences,
 		"find_escape_sequences", FALSE, "check_escape");
 	stash_group_add_toggle_button(group, &settings.find_match_whole_word,
@@ -238,10 +237,10 @@
 	group = stash_group_new("search");
 	replace_prefs = group;
 	configuration_add_pref_group(group, FALSE);
-	stash_group_add_toggle_button(group, &settings.replace_case_sensitive,
-		"replace_case_sensitive", FALSE, "check_case");
 	stash_group_add_toggle_button(group, &settings.replace_regexp,
 		"replace_regexp", FALSE, "check_regexp");
+	stash_group_add_toggle_button(group, &settings.replace_case_sensitive,
+		"replace_case_sensitive", FALSE, "check_case");
 	stash_group_add_toggle_button(group, &settings.replace_escape_sequences,
 		"replace_escape_sequences", FALSE, "check_escape");
 	stash_group_add_toggle_button(group, &settings.replace_match_whole_word,
_______________________________________________
Geany-devel mailing list
[email protected]
https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel

Reply via email to