Hello, While running geany-plugins tests, I hit two failures.
The first one is that cppcheck is not happy about Vala, and since multiterm is fully in Vala, it fails. The second one is that it couldn’t detect an assignment nested in an array. Attached two simple patches to fix these. Cheers -- Quentin "Sardem FF7" Glidic
>From f23646e7700bd965aede63acf3902a3aa0759f5e Mon Sep 17 00:00:00 2001 From: Quentin Glidic <[email protected]> Date: Sun, 25 Mar 2012 12:10:58 +0200 Subject: [PATCH] multiterm: Do not call cppcheck --- multiterm/src/Makefile.am | 2 -- 1 file changed, 2 deletions(-) diff --git a/multiterm/src/Makefile.am b/multiterm/src/Makefile.am index 80a0a90..7878747 100644 --- a/multiterm/src/Makefile.am +++ b/multiterm/src/Makefile.am @@ -35,5 +35,3 @@ multiterm_la_LIBADD = \ $(MULTITERM_LIBS) EXTRA_DIST = multiterm.h - -include $(top_srcdir)/build/cppcheck.mk -- 1.7.9.4
>From db4ec02fdb12ce9ff9481efac814e4f476611d2d Mon Sep 17 00:00:00 2001 From: Quentin Glidic <[email protected]> Date: Sun, 25 Mar 2012 12:12:49 +0200 Subject: [PATCH] debugger: Make cppcheck happy --- debugger/src/dbm_gdb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/debugger/src/dbm_gdb.c b/debugger/src/dbm_gdb.c index efa3c4e..f48b9c0 100644 --- a/debugger/src/dbm_gdb.c +++ b/debugger/src/dbm_gdb.c @@ -1480,7 +1480,8 @@ void update_autos() /* add current autos to the list */ GList *unevaluated = NULL; - const char *gdb_commands[] = { g_strdup_printf("-stack-list-arguments 0 %i %i", active_frame, active_frame), "-stack-list-locals 0" }; + const char *gdb_commands[] = { NULL, "-stack-list-locals 0" }; + gdb_commands[0] = g_strdup_printf("-stack-list-arguments 0 %i %i", active_frame, active_frame); int i, size = sizeof (gdb_commands) / sizeof(char*); for (i = 0; i < size; i++) { -- 1.7.9.4
_______________________________________________ Geany-devel mailing list [email protected] https://lists.uvena.de/cgi-bin/mailman/listinfo/geany-devel
