Hi Robert,
I asked Eric to type up one way of doing the patches; we don't want our
wiki to turn into a git tutorial, but obviously some people could use a
hand. We have no problem with git format-patch (no worries!) but, as
you mentioned, it's a patch per commit, and usually that's not what
we're looking for since some people commit to checkpoint their work.
If you'd like to add your git suggestions to the wiki, please do.
It's open for the community.
-- Jim
On Tue, Mar 26, 2013 at 6:29 PM, Robert Schroll <[email protected]>
wrote:
I use format-patch to, uh, format patches. You may want to mention
this on the contributers' page, since it has several advantages over
diff:
- No need to worry about stdout redirection
- You get a sensible filename without having to think
- You get a patch per commit (but I guess this is only an advantage
if
you're making sure your commits are sensible)
- You get the commit message (again, may or may not be an advantage)
Robert
P.S. I hope I haven't been irritating everyone by sending patches
from
format-patch instead of diff.
On Tue, Mar 26, 2013 at 7:17 PM, Eric Gregory <[email protected]> wrote:
> On Tue, Mar 26, 2013 at 3:47 PM, <[email protected]> wrote:
>
>> Sorry for my second email. I also would extend this
>>
>>
http://redmine.yorba.org/projects/yorba/wiki/GitCodeSubmissionGuidelines
>> with a link to that
>>
>>
>>
http://redmine.yorba.org/projects/yorba/wiki/PatchSubmissionCodeReviews#External-contributor
>>
>> and maybe make this paragraph bold, or at least but something
bold
>> like
>> "NOTICE For external developers:"
>>
>>
>> Note that these guidelines are only for Yorba employees to
>> follow, as external contributors do not have push rights
to
>> our
>> git repo. We plan on soon providing guidelines for
external
>> contributors to submit patches from their remote git
repos.
>>
>>
>> When I was looking for a way to upload my patch, I missunderstood
>> the
>> first instruction (see first mail) and then I was looking for the
>> "real"
>> way. First I didn't read the instruction above, and then it just
>> confused me cause I had no idea how to upload it when not via the
>> push
>> command. So I was reading through a lot of git-tutorials and
didn't
>> get
>> further. So maybe please post a link and format it in a way
>> everybody
>> sees it on the first eye. Uploading the patch took me in the end
>> longer
>> than writing it.
>>
>>
>
> Thanks for the feedback, I've tried to clarify the wording on that
> page. I
> hope it makes more sense now.
>
> - E
> _______________________________________________
> Geary mailing list
> [email protected]
> http://lists.yorba.org/cgi-bin/mailman/listinfo/geary
>
_______________________________________________
Geary mailing list
[email protected]
http://lists.yorba.org/cgi-bin/mailman/listinfo/geary
_______________________________________________
Geary mailing list
[email protected]
http://lists.yorba.org/cgi-bin/mailman/listinfo/geary
