jonnybot0 commented on PR #306: URL: https://github.com/apache/groovy-geb/pull/306#issuecomment-4172981236
Hey, @matrei ! Thanks for including the Gradle build scan. I'm curious, is there a comparison scan for how the tests execute without this change? Grails' tests working with it is a good proof that it should generally work, but I'd like to see a comparison build to demonstrate that it makes some meaningful difference. One tricky thing about a sweeping change like this is that it's hard to discern how it might impact downstream consumers. `CompileStatic` pulls out the meta-object protocol, for example. That's good for a lot of cases, but it's hard to know who's using it. Given that, it seems reasonable to me to assume that this would be a breaking change and should probably go in a major version release. The Grails build indicates pretty broad backward compatibility, but again, hard to be sure. Any thoughts? Feel free to call me out if I'm wrong about the risk. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
