This is an automated email from the ASF dual-hosted git repository. jonnybot pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/groovy-geb.git
commit 5aa9e356bab7f954488f104dd5a1074b71bd3d91 Author: Carl Marcum <[email protected]> AuthorDate: Sat Mar 28 18:36:31 2026 -0400 fix codenarc violations --- .../src/main/groovy/geb/testcontainers/ContainerGebSpec.groovy | 1 - .../groovy/geb/testcontainers/WebDriverContainerHolder.groovy | 8 +++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/integration/geb-testcontainers/src/main/groovy/geb/testcontainers/ContainerGebSpec.groovy b/integration/geb-testcontainers/src/main/groovy/geb/testcontainers/ContainerGebSpec.groovy index 68d6b638..637694ea 100644 --- a/integration/geb-testcontainers/src/main/groovy/geb/testcontainers/ContainerGebSpec.groovy +++ b/integration/geb-testcontainers/src/main/groovy/geb/testcontainers/ContainerGebSpec.groovy @@ -27,7 +27,6 @@ import geb.test.GebTestManager import geb.transform.DynamicallyDispatchesToBrowser import geb.testcontainers.support.ContainerGebFileInputSource import org.testcontainers.containers.BrowserWebDriverContainer -import org.testcontainers.containers.GenericContainer import org.testcontainers.images.builder.Transferable import spock.lang.Shared import spock.lang.Specification diff --git a/integration/geb-testcontainers/src/main/groovy/geb/testcontainers/WebDriverContainerHolder.groovy b/integration/geb-testcontainers/src/main/groovy/geb/testcontainers/WebDriverContainerHolder.groovy index 42b5fb1b..0aa6c71d 100644 --- a/integration/geb-testcontainers/src/main/groovy/geb/testcontainers/WebDriverContainerHolder.groovy +++ b/integration/geb-testcontainers/src/main/groovy/geb/testcontainers/WebDriverContainerHolder.groovy @@ -175,11 +175,9 @@ class WebDriverContainerHolder { // (enforced by ExclusiveResource) so this is safe. System.setProperty(REMOTE_ADDRESS_PROPERTY, container.seleniumAddress.toString()) - if (!gebConf.driverConf) { - gebConf.driverConf = { -> - log.info('Using default Firefox RemoteWebDriver for {}', container.seleniumAddress) - new RemoteWebDriver(container.seleniumAddress, new FirefoxOptions()) - } + gebConf.driverConf = gebConf.driverConf ?: { -> + log.info('Using default Firefox RemoteWebDriver for {}', container.seleniumAddress) + new RemoteWebDriver(container.seleniumAddress, new FirefoxOptions()) } browser = createBrowser(gebConf)
