On Wednesday 17 December 2008 09:37:01 Peter Clifton wrote: > On Wed, 2008-12-17 at 10:26 +0100, Gabriel Paubert wrote: > > Aprt from that, I am the only one still compiling on non-x86 > > machines? > > > > On a machine where char are unsigned by default, there is a > > bug with spectacular side effects (burst of error messages > > ending with segmentation fault) due to a char parameter in > > s_basic_new_object(). When the first parameter is -1, it ends > > up being converted to 255 and stored as such in the object > > structure (where the type is int). > > -1 was OBJ_HEAD IIRC. And actually, it is gone in git HEAD. Try building > from the HEAD now, and see if the bug manifests anywhere else. > > in any case, OBJECT's "type" member is an integer, so I agree that we > should be passing the object type as int. > > Thanks for the patch. Someone should apply it (I will if I remember, but > if someone else with commit access wants to, please do - as I'll not get > to it today). >
Rejected for 1.4.x stable, because it breaks the library ABI.
Peter
--
Peter Brett
Electronic Systems Engineer
Integral Informatics Ltd
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
