On Dec 17, 2008, at 12:48 AM, Peter Clifton wrote: > On Tue, 2008-12-16 at 21:48 -0500, Ales Hvezda wrote: >>> This patch fixes Ales' concerns on selection of solid objects. With >>> solid boxes and circles, users can click in the interior of the >>> shape >>> to select it. Hollow shapes still must be selected on the >>> perimeter. >> >> This patch no longer cleanly (or uncleanly) applies. Is this still >> the >> approach that we want to take? Maybe it's not worth changing anymore >> given that nobody has complained about the behavior for months now >> (?). > > Oops.. I did some editing to those functions (I needed to make the > o_text_shortest_distance() function have the full OBJECT structure, > so I > changed them all and did some tidy-up.
I was going to do that earlier, but was dragging my feet until more feedback came in. I was going to change the o_*_shortest_distance signatures to what you have now, and then move the functionality down to the "geometry layer:" m_circle_shortest_distance(CIRCLE* circle, int x, int y, gboolean solid); m_box_shortest_distance(BOX* box, int x, int y, gboolean solid); m_line_shortest_distance(LINE* line, int x, int y); Either way, let me know... Cheers, Ed _______________________________________________ geda-dev mailing list [email protected] http://www.seul.org/cgi-bin/mailman/listinfo/geda-dev
