On Fri, 9 Jun 2006 17:51:46 -0400 DJ Delorie <[EMAIL PROTECTED]> wrote:
> > Here's a patch to apply after the above patch to get gtk layer > > changes support: > > Thanks! Does it all work well enough that I can apply our two patches > now? Yes, I think so. For sure it's to the point that a bug showing up can be dealt with quickly. > > 3) Now MAX_LAYER is 16 but there are only 8 LAYERCOLOR and > > LAYERSELCOLOR attributes set in the main_attribute_list. > > I think lesstif just assigns a color to the extra layers as needed. > > We don't save color information with boards, so we're going to have > limitations here until we do. Yeah, colors are just a fixed order list. I'll look at assigning the extra colors vs adding more LAYERCOLORS & LAYERSELCOLOR entries. But then if MAX_LAYER is subject to change I guess it would be better to just do the extra assigns in code like you've done with lesstif. > > Also, shouldn't DEF_LAYER be a setting instead of hardwired to 8? > > With it hardwired I can't let the user have the option of setting > > his layer groups preference for new layouts. Or I think better, why > > not derive the DEF_LAYER value from the default groups string? > > My thought on this is to replace "new" with something that loads one > of N templates stored in ~/pcb or $prefix/share. That way, there > don't have to by *any* built-in defaults, aside from incomplete > installs. > > Layer group preferences need to stay symbolic (i.e. "1,2,c:3,4,s:5") > until you apply them to a board with a specific number of layers. I > have no problem deriving DEF_LAYER from the groups string. OK, I'll also look more into this. While using the gtk version it would definitely be nice to be able to do it all from the gui and I'll have to see what it would take to handle a set of templates.
