The fixed size buffer on the heap still makes me nervous: + char buf[1024];
Admittedly, you take care not to read longer than that length from the preferences file, (and fgets takes care of the \0 termination), however the parsing looks like it will be broken if the buffer wrap happens in the middle of a long search path string. Perhaps this isn't a major concern for realistic search paths, but something I thought I'd point out. -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) _______________________________________________ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
