On Thu, Apr 22, 2010 at 03:39:22PM +0100, Peter Clifton wrote: > On Thu, 2010-04-22 at 15:32 +0200, Krzysztof Kościuszkiewicz wrote: > > * Add END_ERASE to OBJECT_END type in libgeda. > > Why? > > I "think" I see what this patch is attempting to do though.. although > the above description really doesn't explain the full story! > > I'm not personally convinced that there is a strong need for > customisable line end types - but if we do want them.. having a dummy > type "END_ERASE" is misleading. It really isn't a good name for a "don't > change anything" place-holder, certainly it isn't a valid line-end type > as the others are.
I agree, though this is directly derived from implementation of TYPE_* enums. I guess this excuse is not good enough :) > gtk_option_menu and friends are deprecated, and should not be used in > new code.. I appreciate you may be copying from existing gschem code, > but that needs to be re-written, rather than copied. (Re-writing that > first and copying the new code reduces the size of the task someone will > eventually have with GTK 3.0). > > FWIW, a brief scan suggests there is a lot more deprecated / poor coding > style in the code which you've copied. You're right, this was done without too much thought. I'll try to rewrite this and resubmit - unless you think that the core of this patch (having an option to edit line end style) is moot... Best regards, -- Krzysztof Kościuszkiewicz "Simplicity is the ultimate sophistication" -- Leonardo da Vinci _______________________________________________ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
