On Sat, 2010-06-05 at 14:38 -0400, DJ Delorie wrote: > > Why are we committing bulk NOP changes like this for anyway? Because > > they exist?
> * Because he was willing to put in the effort to get it committed. > > I really want to encourage people to work on the code and become > contributors, and telling them their hard work is for naught because > someone somewhere might have an uncommitted patch that might be > affected, is not acceptable to me. I was a little out of line earlier with the tone of my complaint earlier, but I still stand by my feelings that mass renames / re-indents, etc.. (without functional benefit) ... should be held off until agreement with the various developers. As it transpires, the impact of this one was relatively minor. (I've had bigger grief with mass re-indents). I try to be supportive of new contributors, so am cross with myself for not having been more so with Robert. Hopefully there will be more changes to come.. but if they are major - perhaps a note on geda-dev or geda-user prior to putting in the hours would be worthwhile. Regards, -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328 - (Shared lab phone, ask for me) _______________________________________________ geda-user mailing list geda-user@moria.seul.org http://www.seul.org/cgi-bin/mailman/listinfo/geda-user
