Ruben Stein a écrit : > Zitat von Vladimir Nadvornik <nadvor...@suse.cz>: > >> The flashing really does not look very good. Maybe use fixed-size >> formatting? > > I used some kind of a fixed-size now - by computing the maximum char > length out of the image dimensions as indentation parameters, and > printing a monospace font. > >> So store only pixel coordinates then? Having both means extra care to >> keep them synchronized. >> >> BTW, hardcoded layout_status_update_pixel call is not very good. IMO >> correct >> way would be to use a signal (grep for "scroll_notify" to see how to >> implement this): layout will register a callback when it wants to be >> informed >> about pixel changes and from the callback queries the pixbuf-renderer >> for >> details. > > I implemented it this way now. Looks much cleaner. Pixel coordinates > are now passed as parameter to the getter of colors, since they are > not stored in pr anymore. > > I think I like it now. It remains to be seen if I missed any special > case in the signal infrastructure where it won't get updated. Thanks > again for the comments. > > Good night - Ruben > Thank you, Ruben. The patch is far more cleaner now. Please can you just modify it putting all variables declarations at the top of functions (as indicated in CODING document) ? After that it will be ready to be committed to the current tree, further improvements can be made later.
Thank you very much for contributing. -- Laurent Monin aka Zas ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
