----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/750/#review1382 -----------------------------------------------------------
Ship it! Thanks! This seems less convoluted. As you mentioned before, since the x86 versions have different type signatures you could throw all the helper functions in a single file (though if you do that I would definitely make the x86 getMem() more symmetric by making it a void function and returning the data via a reference param), but unless/until the unlikely event that we have another ISA that needs those helpers this seems fine to me. - Steve On 2011-07-02 04:23:03, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/750/ > ----------------------------------------------------------- > > (Updated 2011-07-02 04:23:03) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ISA: Use readBytes/writeBytes for all instruction level memory operations. > > > Diffs > ----- > > src/arch/alpha/isa/main.isa 4adb1148ef73 > src/arch/alpha/isa/mem.isa 4adb1148ef73 > src/arch/arm/isa/includes.isa 4adb1148ef73 > src/arch/arm/isa/templates/mem.isa 4adb1148ef73 > src/arch/generic/memhelpers.hh PRE-CREATION > src/arch/mips/isa/formats/mem.isa 4adb1148ef73 > src/arch/mips/isa/includes.isa 4adb1148ef73 > src/arch/power/isa/formats/mem.isa 4adb1148ef73 > src/arch/power/isa/includes.isa 4adb1148ef73 > src/arch/sparc/isa/formats/mem/swap.isa 4adb1148ef73 > src/arch/sparc/isa/formats/mem/util.isa 4adb1148ef73 > src/arch/sparc/isa/includes.isa 4adb1148ef73 > src/arch/x86/insts/microldstop.hh 4adb1148ef73 > src/arch/x86/isa/includes.isa 4adb1148ef73 > src/arch/x86/isa/microops/ldstop.isa 4adb1148ef73 > src/arch/x86/memhelpers.hh PRE-CREATION > > Diff: http://reviews.m5sim.org/r/750/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
