----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/771/#review1402 -----------------------------------------------------------
Ship it! Looks fine to me... A quick check to verify that we don't have a memory leak would be nice. - Ali On 2011-07-04 02:08:52, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/771/ > ----------------------------------------------------------- > > (Updated 2011-07-04 02:08:52) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Translation: Use a pointer type as the template argument. > > This allows regular pointers and reference counted pointers without having to > use any shim structures or other tricks. > > > Diffs > ----- > > src/cpu/base_dyn_inst.hh 1b4b9c05ad2b > src/cpu/simple/timing.cc 1b4b9c05ad2b > src/cpu/translation.hh 1b4b9c05ad2b > > Diff: http://reviews.m5sim.org/r/771/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
