----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/792/#review1423 -----------------------------------------------------------
Looks reasonable to me. Can you add an example to the statistics unittest? src/base/statistics.hh <http://reviews.m5sim.org/r/792/#comment1849> Sort includes src/base/stats/text.cc <http://reviews.m5sim.org/r/792/#comment1851> Random whitespace src/base/stats/types.hh <http://reviews.m5sim.org/r/792/#comment1850> sort includes - Nathan On 2011-07-15 09:40:54, Ali Saidi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/792/ > ----------------------------------------------------------- > > (Updated 2011-07-15 09:40:54) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Stats: Add a sparse histogram stat object. > > > Diffs > ----- > > src/base/statistics.hh 82ff928182c5 > src/base/stats/info.hh 82ff928182c5 > src/base/stats/output.hh 82ff928182c5 > src/base/stats/text.hh 82ff928182c5 > src/base/stats/text.cc 82ff928182c5 > src/base/stats/types.hh 82ff928182c5 > src/python/swig/stats.i 82ff928182c5 > > Diff: http://reviews.m5sim.org/r/792/diff > > > Testing > ------- > > > Thanks, > > Ali > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
