This fixes the "invalid microop" bug people have been seeing on m5-users. There's another bug in the simple timing CPU where it just stops executing instructions after a while in X86_FS and I'm still looking into that. I haven't tried X86_FS with O3 yet and there may be a hiccup or two. Other than that the quick regressions on X86_SE and X86_FS work with this patch.
Gabe On 09/04/11 19:45, Gabe Black wrote: > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/836/ > ----------------------------------------------------------- > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > X86: Make sure instruction flags are set properly even on 32 bit machines. > > The way flag bits were being set for microops in x86 ended up implicitly > calling the bitset constructor which was truncating flags beyond the width of > an unsigned long. This change sets the bits in chunks which are always small > enough to avoid being truncated. On 64 bit machines this should reduce to be > the same as before, and on 32 bit machines it should work properly and not be > unreasonably inefficient. > > > Diffs > ----- > > src/arch/x86/insts/microop.hh 09745e0c3dd9 > > Diff: http://reviews.m5sim.org/r/836/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
