----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/829/#review1496 -----------------------------------------------------------
Ship it! I'm pretty ambivalent about this one... the status quo may be a little overcomplicated, but that never bothered me, and the new version doesn't seem that much simpler (especially since you now have to include a file instead of just forward declaring StaticInstPtr). I'm guessing you have a good reason for doing this though. - Steve On 2011-08-16 03:08:42, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/829/ > ----------------------------------------------------------- > > (Updated 2011-08-16 03:08:42) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > StaticInst: Merge StaticInst and StaticInstBase. > > Having two StaticInst classes, one nominally ISA dependent and the other ISA > dependent, has not been historically useful and makes the StaticInst class > more complicated that it needs to be. This change merges StaticInstBase into > StaticInst. > > > Diffs > ----- > > src/arch/alpha/isa_traits.hh 889818c58eff > src/arch/arm/insts/macromem.cc 889818c58eff > src/arch/arm/isa_traits.hh 889818c58eff > src/arch/mips/isa_traits.hh 889818c58eff > src/arch/power/isa_traits.hh 889818c58eff > src/arch/sparc/isa_traits.hh 889818c58eff > src/arch/x86/insts/badmicroop.hh 889818c58eff > src/arch/x86/isa_traits.hh 889818c58eff > src/cpu/base_dyn_inst.hh 889818c58eff > src/cpu/inorder/inorder_dyn_inst.hh 889818c58eff > src/cpu/static_inst.hh 889818c58eff > src/cpu/static_inst_fwd.hh PRE-CREATION > > Diff: http://reviews.m5sim.org/r/829/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
