> On 2011-09-07 12:09:40, Steve Reinhardt wrote: > > src/arch/isa_parser.py, line 859 > > <http://reviews.m5sim.org/r/841/diff/1/?file=14827#file14827line859> > > > > re.MULTILINE only affects how '^ 'and '$' are interpreted, not '.'. > > You need DOTALL to make '.' match newlines (which then makes the '//.*\n' > > not work right). Based on this, the regex that Ali posted looks more > > reasonable.
I should say "more likely to be correct", not "more reasonable"... by some definitions that regex is rather unreasonable... :-) - Steve ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/841/#review1500 ----------------------------------------------------------- On 2011-09-05 22:34:45, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/841/ > ----------------------------------------------------------- > > (Updated 2011-09-05 22:34:45) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > ISA parser: Match /* */ and // style comments. > > Comments should not be scanned for operands, and we should look for both /* */ > style and // style. The regular expression is still not quite right because it > doesn't handle comments in strings, but it's closer. > > > Diffs > ----- > > src/arch/isa_parser.py 1f95c9a0bb2f > > Diff: http://reviews.m5sim.org/r/841/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
