----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/851/#review1520 -----------------------------------------------------------
src/cpu/inorder/inorder_dyn_inst.cc <http://reviews.m5sim.org/r/851/#comment2030> Why not have this be a if () instead of a #if? I'm assuming the ultimate plan is to make FULLL_SYSTEM a boolean and not a processor directive. - Ali On 2011-09-10 03:12:58, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/851/ > ----------------------------------------------------------- > > (Updated 2011-09-10 03:12:58) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Syscall: Make the syscall function available in both SE and FS modes. > > In FS mode the syscall function will panic, but the interface will be > consistent and code which calls syscall can be compiled in. This will allow, > for instance, instructions that use syscall to be built unconditionally but > then not returned by the decoder. > > > Diffs > ----- > > src/cpu/inorder/inorder_dyn_inst.hh 9678812ccb62 > src/cpu/inorder/inorder_dyn_inst.cc 9678812ccb62 > src/cpu/o3/dyn_inst.hh 9678812ccb62 > src/cpu/o3/dyn_inst_impl.hh 9678812ccb62 > src/cpu/simple/base.hh 9678812ccb62 > > Diff: http://reviews.m5sim.org/r/851/diff > > > Testing > ------- > > > Thanks, > > Gabe > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
