----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/890/#review1605 -----------------------------------------------------------
src/dev/ide_ctrl.cc <http://reviews.m5sim.org/r/890/#comment2084> Does leaving this line out cause something not to work? I see that it's used for the primary controller so this makes them symmetrical. I don't remember what ctrlOffset is for so I don't know for sure if they *should* be symmetrical. If this fixed a failure of some kind then they probably should be. src/dev/ide_disk.cc <http://reviews.m5sim.org/r/890/#comment2085> Why are you removing these panics and the constants they depend on? If they were going off before, then there's something that may need to be fixed. If they started going off when you changed the BARs below, then they weren't wrong at all, they just needed to be updated. But as I say below, I'm not convinced that the BARs should be changed. src/dev/x86/SouthBridge.py <http://reviews.m5sim.org/r/890/#comment2086> I don't think these changes to the BARs are correct, and I don't see why this would matter when restoring a checkpoint. - Gabe On 2011-10-10 17:55:10, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/890/ > ----------------------------------------------------------- > > (Updated 2011-10-10 17:55:10) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > IDE Disk: Bring it inline with QEMU > I have made some changes to the IDE Disk's ports so that it is inline with > QEMU. I am able to boot Linux 2.6.28.4 for x86 with these changes. > > > Diffs > ----- > > src/dev/ide_ctrl.cc 30a97c4198df > src/dev/ide_disk.hh 30a97c4198df > src/dev/ide_disk.cc 30a97c4198df > src/dev/x86/SouthBridge.py 30a97c4198df > > Diff: http://reviews.m5sim.org/r/890/diff > > > Testing > ------- > > > Thanks, > > Nilay > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
