----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/915/#review1777 -----------------------------------------------------------
Removed derived class. Added two uint16_t's: bytesValidStart and bytesValidEnd to Packet class to represent the range of values copied in a partial read. Added back functionality in Packet class to satisfy partial functional read. Tested with CheckerCPU to see if I hit any dis-contiguous byte ranges. Nothing triggered the panic for this case. Anybody have recommendations for the variables I used to construct the range checks to figure out which bytes to copy instead of a,b,c, and d? I did put extensive comments in the code to explain what they were being used for. - Geoffrey On 2011-12-21 12:35:12, Geoffrey Blake wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/915/ > ----------------------------------------------------------- > > (Updated 2011-12-21 12:35:12) > > > Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and > Nathan Binkert. > > > Summary > ------- > > Packet: Enable functional reads of partial data to packet class > > This patch fixes a long standing defficiency in the packet class where > it was unable to handle finding data that partially satisfied a request. > > This splits out changes made to the packet class in the checkercpu patch as > requested by Ali. > > > Diffs > ----- > > src/mem/packet.hh c1ab57ea8805 > src/mem/packet.cc c1ab57ea8805 > > Diff: http://reviews.m5sim.org/r/915/diff > > > Testing > ------- > > Compiles. No functional changes made from CheckerCPU patch to this patch for > packet class, and CheckerCPU fully exercised this code path during testing. > > > Thanks, > > Geoffrey > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
