changeset 5637ed211912 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=5637ed211912
description:
        Alpha: warn_once about broken PAL breakpoints.

        A recent changeset (aae12ce9f34c) removed support for
        PAL-mode breakpoints in Alpha, since it was awkward
        and likely unused.  This patch lets a user know if they
        potentially run into this limitation.

diffstat:

 src/arch/alpha/remote_gdb.cc |  8 ++++++++
 src/arch/alpha/remote_gdb.hh |  2 ++
 src/base/remote_gdb.hh       |  2 +-
 3 files changed, 11 insertions(+), 1 deletions(-)

diffs (39 lines):

diff -r d1a507c6329a -r 5637ed211912 src/arch/alpha/remote_gdb.cc
--- a/src/arch/alpha/remote_gdb.cc      Mon Jan 16 19:00:59 2012 -0800
+++ b/src/arch/alpha/remote_gdb.cc      Mon Jan 16 19:01:27 2012 -0800
@@ -314,3 +314,11 @@
     }
 }
 
+
+bool
+RemoteGDB::insertHardBreak(Addr addr, size_t len)
+{
+    warn_once("Breakpoints do not work in Alpha PAL mode.\n"
+              "      See PCEventQueue::doService() in cpu/pc_event.cc.\n");
+    return BaseRemoteGDB::insertHardBreak(addr, len);
+}
diff -r d1a507c6329a -r 5637ed211912 src/arch/alpha/remote_gdb.hh
--- a/src/arch/alpha/remote_gdb.hh      Mon Jan 16 19:00:59 2012 -0800
+++ b/src/arch/alpha/remote_gdb.hh      Mon Jan 16 19:01:27 2012 -0800
@@ -63,6 +63,8 @@
     bool acc(Addr addr, size_t len);
     bool write(Addr addr, size_t size, const char *data);
 
+    virtual bool insertHardBreak(Addr addr, size_t len);
+
   public:
     RemoteGDB(System *system, ThreadContext *context);
 };
diff -r d1a507c6329a -r 5637ed211912 src/base/remote_gdb.hh
--- a/src/base/remote_gdb.hh    Mon Jan 16 19:00:59 2012 -0800
+++ b/src/base/remote_gdb.hh    Mon Jan 16 19:01:27 2012 -0800
@@ -216,7 +216,7 @@
 
     bool insertSoftBreak(Addr addr, size_t len);
     bool removeSoftBreak(Addr addr, size_t len);
-    bool insertHardBreak(Addr addr, size_t len);
+    virtual bool insertHardBreak(Addr addr, size_t len);
     bool removeHardBreak(Addr addr, size_t len);
 
   protected:
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev

Reply via email to