----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1000/#review2039 -----------------------------------------------------------
Ship it! Ship It! - Ali Saidi On Jan. 18, 2012, 2:31 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1000/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2012, 2:31 a.m.) > > > Review request for Default. > > > Description > ------- > > MEM: Remove onRetryList from BusPort and rely on retryList > > This patch removes the onRetryList field from the BusPort class and > entirely relies on the retryList which holds all ports that are > waiting to retry. The onRetryList field and the retryList were > previously used with overloaded functionalities and only one is really > needed (there were also checks to assert they held the same > information). After this patch the bus ports will be split into master > and slave ports and this simplifies that transition. > > > Diffs > ----- > > src/mem/bus.hh 03e09db82c80 > src/mem/bus.cc 03e09db82c80 > > Diff: http://reviews.gem5.org/r/1000/diff/diff > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
