> On Feb. 2, 2012, 8:37 a.m., Steve Reinhardt wrote: > > src/cpu/o3/fetch_impl.hh, line 543 > > <http://reviews.gem5.org/r/1019/diff/1/?file=21619#file21619line543> > > > > Would it be equivalent to check fetchStatus[tid] == Squashing here? I > > know the name of the flag is not perfect, but it seems wrong to check a > > flag called "delayedCommit" in the fetch stage. Checking fetchStatus seems > > more intuitive.
I want to eliminate that flag and in fact the entire business of checking for interrupts in the fetch stage. I tried doing it but things did not work out. And debugging the O3 CPU is not all that easy either. To answer your question, the flag has been put in place to check whether or not the previously fetched microop was marked delayed commit. This has nothing to do with whether or not fetch stage is squashing instructions. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1019/#review2053 ----------------------------------------------------------- On Jan. 28, 2012, 9:02 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1019/ > ----------------------------------------------------------- > > (Updated Jan. 28, 2012, 9:02 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8733:46a19d5999bd > --------------------------- > O3 CPU: Improve handling of delayed commit flag > The delayed commit flag is used in conjunction with interrupt pending flag to > figure out whether or not fetch stage should get more instructions. This patch > clears this flag when instructions are squashed. Also, in case an interrupt is > pending, currently it is not possible to access the instruction cache. This > patch allows accessing the cache in case this flag is set. > > > Diffs > ----- > > src/cpu/o3/fetch_impl.hh 9d7c1dc54954 > > Diff: http://reviews.gem5.org/r/1019/diff/diff > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
