----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1004/#review2110 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On Feb. 9, 2012, 11:47 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1004/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2012, 11:47 a.m.) > > > Review request for Default. > > > Description > ------- > > MEM: Explicit ports and Python binding on CopyEngine > > The copy-engine ports were previously created implicitly and bound > based on the dma port peer rather than relying on the normal Python > binding (connectPorts) being called explicitly. This patch makes the > copy engine port similar to all other ports in that they are visibly > in the Python class and bound using the normal explicit calls through > Python. > > > Diffs > ----- > > src/dev/CopyEngine.py 4f2ad221ae32 > src/dev/copy_engine.hh 4f2ad221ae32 > src/dev/copy_engine.cc 4f2ad221ae32 > > Diff: http://reviews.gem5.org/r/1004/diff/diff > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
