> On Feb. 9, 2012, 2:08 a.m., Gabe Black wrote: > > tests/long/fs/10.linux-boot/test.py, line 30 > > <http://reviews.gem5.org/r/1033/diff/1/?file=23075#file23075line30> > > > > I'm not sure you should do things this way. I think it would be cleaner > > to create a new configuration like realview-o3-checker.py which is the same > > but turns on the checker.
Yeah, now that you mention this, I found the actual config files for the regressions. Will be posting a diff soon that will fix this. > On Feb. 9, 2012, 2:08 a.m., Gabe Black wrote: > > tests/quick/se/00.hello/test.py, line 36 > > <http://reviews.gem5.org/r/1033/diff/1/?file=23076#file23076line36> > > > > The checker for the simple CPU doesn't seem to make a lot of sense. In > > that case it should just have a NULL checker. This test is really just to make sure the DummyChecker object is getting connected correctly and doesn't error out when its connected. - Geoffrey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1033/#review2101 ----------------------------------------------------------- On Feb. 8, 2012, 7:48 a.m., Geoffrey Blake wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1033/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2012, 7:48 a.m.) > > > Review request for Default. > > > Description > ------- > > CheckerCPU: Make some basic regression tests for CheckerCPU > > Dual purposes the se/00.hello and fs/10.linux-boot regression tests as > tests for the CheckerCPU for the ARM ISA only. > > > Diffs > ----- > > tests/long/fs/10.linux-boot/test.py 8f354c5a1634 > tests/quick/se/00.hello/test.py 8f354c5a1634 > > Diff: http://reviews.gem5.org/r/1033/diff/diff > > > Testing > ------- > > Compiles. > The se/00.hello an fs/10.linux-boot tests run to completion sucessfully. > > > Thanks, > > Geoffrey Blake > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
