----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1074/ -----------------------------------------------------------
Review request for Default. Description ------- CPU: Check that the interrupt controller is created when needed This patch adds a creation-time check to the CPU to ensure that the interrupt controller is created for the cases where it is needed, i.e. if the CPU is not being switched in later and not a checker CPU. The patch also adds the "createInterruptController" call to a number of the regression scripts. Diffs ----- src/cpu/base.hh 9f1c4729d89d src/cpu/base.cc 9f1c4729d89d src/cpu/checker/cpu.cc 9f1c4729d89d src/cpu/inorder/cpu.cc 9f1c4729d89d src/cpu/o3/cpu.cc 9f1c4729d89d tests/configs/inorder-timing.py 9f1c4729d89d tests/configs/o3-timing-mp-ruby.py 9f1c4729d89d tests/configs/o3-timing-mp.py 9f1c4729d89d tests/configs/o3-timing-ruby.py 9f1c4729d89d tests/configs/o3-timing.py 9f1c4729d89d tests/configs/pc-o3-timing.py 9f1c4729d89d tests/configs/pc-simple-atomic.py 9f1c4729d89d tests/configs/pc-simple-timing.py 9f1c4729d89d tests/configs/realview-o3-dual.py 9f1c4729d89d tests/configs/realview-o3.py 9f1c4729d89d tests/configs/realview-simple-atomic-dual.py 9f1c4729d89d tests/configs/realview-simple-atomic.py 9f1c4729d89d tests/configs/realview-simple-timing-dual.py 9f1c4729d89d tests/configs/realview-simple-timing.py 9f1c4729d89d tests/configs/simple-atomic-mp.py 9f1c4729d89d tests/configs/simple-atomic.py 9f1c4729d89d tests/configs/simple-timing-mp.py 9f1c4729d89d tests/configs/simple-timing-ruby.py 9f1c4729d89d tests/configs/simple-timing.py 9f1c4729d89d tests/configs/tsunami-o3-dual.py 9f1c4729d89d tests/configs/tsunami-o3.py 9f1c4729d89d tests/configs/tsunami-simple-atomic-dual.py 9f1c4729d89d tests/configs/tsunami-simple-atomic.py 9f1c4729d89d tests/configs/tsunami-simple-timing-dual.py 9f1c4729d89d tests/configs/tsunami-simple-timing.py 9f1c4729d89d tests/configs/twosys-tsunami-simple-atomic.py 9f1c4729d89d Diff: http://reviews.gem5.org/r/1074/diff/ Testing ------- util/regress quick passing (disregarding t1000 and eio and statsdiff for realview tests) Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
