----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1077/#review2271 -----------------------------------------------------------
Looks great? Have you tested it? I assume it works? Our commit messages are supposed to be of the format: <one word>: <summary> <detail> Could you change it to something like: IGbE: Fix writeback conditions for i8254x GbE in updated data sheet. An older revision of the data sheet specified that txdctl.gran was 1 the granularity was based on cache block and gran being 0 is based on descriptor count. The newer version of the data sheet reverses this errata. src/dev/i8254xGBe.cc <http://reviews.gem5.org/r/1077/#comment2699> Could you remove the == 0 and just use a !? - Ali Saidi On March 3, 2012, 12:34 p.m., Pritha Ghoshal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1077/ > ----------------------------------------------------------- > > (Updated March 3, 2012, 12:34 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8849:29218340fa69 > --------------------------- > Modifying writeback conditions for i8254xgbe for updated datasheet > > > Diffs > ----- > > src/dev/i8254xGBe.cc 2629f0b99e8d > > Diff: http://reviews.gem5.org/r/1077/diff/ > > > Testing > ------- > > > Thanks, > > Pritha Ghoshal > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
