Why not just convert to csprintf? None of that llX lx lx nonsense. It just figures it out.
Nate On Thu, Mar 22, 2012 at 6:58 AM, Andreas Hansson <[email protected]> wrote: > Hi all, > > It seems the patch I pushed that ubiquitously uses -Werror causes compilation > to fail on 32-bit hosts due to the following in ruby/common/Set.cc: > > #ifdef _LP64 > sprintf(buff,"0x %016llX ", (long long)m_p_nArray[i]); > #else > sprintf(buff,"%08X ", m_p_nArray[i]); > #endif // __32BITS__ > > I am tempted to remove the ifdef and simply make this: > > sprintf(buff,"%08lX ", m_p_nArray[i]); > > Is there a reason why we should keep the ifdef? The m_p_nArray always > contains longs. > > Andreas > > > -- IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > _______________________________________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/gem5-dev _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
