----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1114/#review2377 -----------------------------------------------------------
Ship it! If there's a possibility of using the work item count stuff in SE mode, then this does make sense. If not, then to me it's a wash, but I don't oppose it... - Steve Reinhardt On March 24, 2012, 1:26 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1114/ > ----------------------------------------------------------- > > (Updated March 24, 2012, 1:26 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8917:e62bbcee43c2 > --------------------------- > Config: Move setWorkCountOptions() to Simulation.py > The function is presently defined in FSConfig.py, which does not seem to be > the correct place for it. > > > Diffs > ----- > > configs/common/FSConfig.py 7d95b650c9b6 > configs/common/Simulation.py 7d95b650c9b6 > configs/example/fs.py 7d95b650c9b6 > configs/example/ruby_fs.py 7d95b650c9b6 > > Diff: http://reviews.gem5.org/r/1114/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
