----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1116/ -----------------------------------------------------------
(Updated March 27, 2012, 10:24 a.m.) Review request for Default. Description ------- CPU: Unify initMemProxies across CPUs and simulation modes This patch unifies where initMemProxies is called, in the init() method of each BaseCPU subclass, before TheISA::initCPU is called. Moreover, it also ensures that initMemProxies is called in both full-system and syscall-emulation mode, thus unifying also across the modes. An additional check is added in the ThreadState to ensure that initMemProxies is only called once. Diffs ----- src/cpu/thread_state.cc 50d1b7dbd23c src/cpu/thread_state.hh 50d1b7dbd23c src/cpu/simple/timing.cc 50d1b7dbd23c src/cpu/simple/atomic.cc 50d1b7dbd23c src/cpu/o3/cpu.cc 50d1b7dbd23c src/cpu/inorder/cpu.cc 50d1b7dbd23c Diff: http://reviews.gem5.org/r/1116/diff/ Testing (updated) ------- util/regress all passing (disregarding t1000 and eio) Additionally, resuming from a checkpoint with O3 CPU with the Linux thread info enabled no longer causes a seg fault. Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
