> On March 28, 2012, 1:59 p.m., Brad Beckmann wrote: > > While I can understand that this may be a slightly easier way to deal with > > options, I'm not sure if the benefits out-weight the cost. This is > > definitely one of those changes that will cause a lot of tedious downstream > > work. Can we just keep it the way it is?
What are the costs and the intended benefits? I'm assuming this is to reduce the amount of duplicate code which is good, but it also has the side effect of making the scripts more dependent on each other. I'm not necessarily advocating doing one thing or the other (and this is already checked in, I think), but it would be nice to be more explicit about what we're getting and what we're paying for it so we can make a more objective decision. This is the first I've looked at this, but I'm assuming Steve and Ali have already weighed the pros and cons which is why they were ok with it going in. Generally speaking, downstream should not have a big pile of code that needs to be updated, and if it does that shouldn't prevent fixing things in the main repository which lots of other people use. The important thing to figure out is if we're improving something or just changing it. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1115/#review2390 ----------------------------------------------------------- On March 27, 2012, 4:38 p.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1115/ > ----------------------------------------------------------- > > (Updated March 27, 2012, 4:38 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8921:9328fdaf0992 > --------------------------- > Config: Change the way options are added > I am not too happy with the way options are added in files se.py and fs.py > currently. This patch moves all the options to the file Options.py, functions > from which are called when required. > > > Diffs > ----- > > configs/example/se.py c1366a30d5eb > tests/configs/memtest-ruby.py c1366a30d5eb > tests/configs/rubytest-ruby.py c1366a30d5eb > tests/configs/simple-timing-mp-ruby.py c1366a30d5eb > tests/configs/simple-timing-ruby.py c1366a30d5eb > configs/example/fs.py c1366a30d5eb > configs/example/ruby_fs.py c1366a30d5eb > configs/common/Options.py c1366a30d5eb > > Diff: http://reviews.gem5.org/r/1115/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
