----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1149/#review2549 -----------------------------------------------------------
Ship it! Ship It! - Andreas Hansson On April 15, 2012, 1:17 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1149/ > ----------------------------------------------------------- > > (Updated April 15, 2012, 1:17 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 8955:2bf74bb6f41d > --------------------------- > CPU: Tidy up some formatting and a DPRINTF in the simple CPU base class. > > Put the { on the same line as the if and put a space between the if and the > open paren. Also, use the # format modifier which puts a 0x in front of hex > values automatically. If the ExtMachInst type isn't integral and actually > prints something more complicated, the # falls away harmlessly and we aren't > left with a phantom 0x followed by a bunch of unrelated text. > > > Diffs > ----- > > src/cpu/simple/base.cc 3c7232fec7fd > > Diff: http://reviews.gem5.org/r/1149/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
