I see. The lack of tolerance for a space is because you're providing a string value as the default for a command-line parameter (where spaces normally wouldn't be present anyway), not a python list... similar to my original confusion.
That said, the split_if_nonempty() method could be tweaked to strip leading spaces if we cared. Steve On Thu, Apr 26, 2012 at 7:24 AM, Nilay Vaish <[email protected]> wrote: > I was using util/regress but I was specifying the 'builds' option. Hence I > failed to capture this problem. It seems there are two problems. One is the > missing is comma, and surprisingly there cannot be a space between ',' and > X86_MESI_CMP_directory. > > -- > Nilay > > > On Thu, 26 Apr 2012, Steve Reinhardt wrote: > > The bug is in util/regress (see below), but my quick diagnosis was wrong >> in >> the details... I just glanced at the diff and didn't notice that the thing >> you changed is really a long string split across several lines and not a >> list. I think the actual issue is that you're missing a comma. >> >> Here's the regression output; note the problems at the end of the scons >> args generated by util/regress. >> >> pulling from http://repo.gem5.org/gem5 >> searching for changes >> adding changesets >> adding manifests >> adding file changes >> added 5 changesets with 21 changes to 19 files >> 19 files updated, 0 files merged, 0 files removed, 0 files unresolved >> pulling from >> http://repo.gem5.org/**encumbered<http://repo.gem5.org/encumbered> >> searching for changes >> no changes found >> Error: no non-leaf 'build' dir found on target path >> /z/m5/regression/zizzer/gem5/**build >> Child returned 1 >> When attemping to execute: scons --ignore-style -k USE_MYSQL=no RUBY=True >> -j 7 -Q build/ALPHA/gem5.debug build/ALPHA_MOESI_hammer/gem5.**debug >> build/ALPHA_MESI_CMP_**directory/gem5.debug >> build/ALPHA_MOESI_CMP_**directory/gem5.debug >> build/ALPHA_MOESI_CMP_token/**gem5.debug build/MIPS/gem5.debug >> build/POWER/gem5.debug build/SPARC/gem5.debug build/X86/gem5.debug build/ >> X86_MESI_CMP_directoryARM/**gem5.debug build/ALPHA/gem5.fast >> build/ALPHA_MOESI_hammer/gem5.**fast build/ALPHA_MESI_CMP_** >> directory/gem5.fast >> build/ALPHA_MOESI_CMP_**directory/gem5.fast >> build/ALPHA_MOESI_CMP_token/**gem5.fast build/MIPS/gem5.fast >> build/POWER/gem5.fast build/SPARC/gem5.fast build/X86/gem5.fast build/ >> X86_MESI_CMP_directoryARM/**gem5.fast build/ALPHA/tests/opt/quick/se >> build/ALPHA/tests/opt/quick/fs build/ALPHA_MOESI_hammer/** >> tests/opt/quick/se >> build/ALPHA_MOESI_hammer/**tests/opt/quick/fs >> build/ALPHA_MESI_CMP_**directory/tests/opt/quick/se >> build/ALPHA_MESI_CMP_**directory/tests/opt/quick/fs >> build/ALPHA_MOESI_CMP_**directory/tests/opt/quick/se >> build/ALPHA_MOESI_CMP_**directory/tests/opt/quick/fs >> build/ALPHA_MOESI_CMP_token/**tests/opt/quick/se >> build/ALPHA_MOESI_CMP_token/**tests/opt/quick/fs >> build/MIPS/tests/opt/quick/se build/MIPS/tests/opt/quick/fs >> build/POWER/tests/opt/quick/se build/POWER/tests/opt/quick/fs >> build/SPARC/tests/opt/quick/se build/X86/tests/opt/quick/se >> build/X86/tests/opt/quick/fs build/ >> X86_MESI_CMP_directoryARM/**tests/opt/quick/se build/ >> X86_MESI_CMP_directoryARM/**tests/opt/quick/fs >> Child returned 1 >> When attemping to execute: util/regress '--scons-opts' '-k USE_MYSQL=no >> RUBY=True -j 7 -Q' 'quick' >> >> >> On Thu, Apr 26, 2012 at 6:52 AM, Steve Reinhardt <[email protected]> >> wrote: >> >> Yes, your change to util/regress is bad, you have a comma inside a string >>> instead of outside. >>> >>> You should actually use util/regress to run regressions before you >>> commit, >>> since that's what the nightly regression script does. Then you would >>> have >>> caught this beforehand. >>> >>> Steve >>> >>> On Thu, Apr 26, 2012 at 6:23 AM, Nilay Vaish <[email protected]> wrote: >>> >>> Can some one check what went wrong? It is likely that I committed some >>>> mistake. >>>> >>>> -- >>>> Nilay >>>> >>>> >>>> On Thu, 26 Apr 2012, Cron Daemon wrote: >>>> >>>> >>>> See /z/m5/regression/regress-2012-04-26-03:00:****01 for details. >>>>> >>>>> ______________________________****_________________ >>>>> gem5-dev mailing list >>>>> [email protected] >>>>> http://m5sim.org/mailman/****listinfo/gem5-dev<http://m5sim.org/mailman/**listinfo/gem5-dev> >>>>> <http://**m5sim.org/mailman/listinfo/**gem5-dev<http://m5sim.org/mailman/listinfo/gem5-dev> >>>>> > >>>>> >>>>> ______________________________****_________________ >>>>> >>>> gem5-dev mailing list >>>> [email protected] >>>> http://m5sim.org/mailman/****listinfo/gem5-dev<http://m5sim.org/mailman/**listinfo/gem5-dev> >>>> <http://**m5sim.org/mailman/listinfo/**gem5-dev<http://m5sim.org/mailman/listinfo/gem5-dev> >>>> > >>>> >>>> >>> >>> ______________________________**_________________ >> gem5-dev mailing list >> [email protected] >> http://m5sim.org/mailman/**listinfo/gem5-dev<http://m5sim.org/mailman/listinfo/gem5-dev> >> >> ______________________________**_________________ > gem5-dev mailing list > [email protected] > http://m5sim.org/mailman/**listinfo/gem5-dev<http://m5sim.org/mailman/listinfo/gem5-dev> > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
