----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1183/#review2731 -----------------------------------------------------------
Unless required, try to not include the stat updates in patches. They kind of clutter the patch. configs/common/FSConfig.py <http://reviews.gem5.org/r/1183/#comment3081> I think you inadvertently deleted a line here. configs/example/fs.py <http://reviews.gem5.org/r/1183/#comment3083> Can the comma appear on the previous line? - Nilay Vaish On May 18, 2012, 1:26 p.m., Jayneel Gandhi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1183/ > ----------------------------------------------------------- > > (Updated May 18, 2012, 1:26 p.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9008:868c58107488 > --------------------------- > Config: Make disk-image option support mutiple disks > Added support to specify mutiple disks provided on command line with > disk-image option. Made the required changes to SysConfig to support that. > Updated regressions to accomodate the stat name changes and change in > SysConfig. When you use this option, you have to specify disks in specific > order and the default disks for the system also needs to be specified. > The operating system disk is to be specified first in the comma-spearated > list. > The new disks that you specify can be mounted by using mount command once the > operating system is booted. Like for X86 linux, you can mount the new disk > from > /dev/hdc, if the option was used as --mem-disk=linux disk,swap disk,new disk. > > > Diffs > ----- > > configs/common/Benchmarks.py 7100059f7bfd > configs/common/FSConfig.py 7100059f7bfd > configs/common/Options.py 7100059f7bfd > configs/example/fs.py 7100059f7bfd > tests/configs/pc-o3-timing.py 7100059f7bfd > tests/configs/pc-simple-atomic.py 7100059f7bfd > tests/configs/pc-simple-timing-ruby.py 7100059f7bfd > tests/configs/pc-simple-timing.py 7100059f7bfd > tests/long/fs/10.linux-boot/ref/alpha/linux/tsunami-o3-dual/stats.txt > 7100059f7bfd > tests/long/fs/10.linux-boot/ref/alpha/linux/tsunami-o3/stats.txt > 7100059f7bfd > tests/long/fs/10.linux-boot/ref/arm/linux/realview-o3-checker/stats.txt > 7100059f7bfd > tests/long/fs/10.linux-boot/ref/arm/linux/realview-o3-dual/stats.txt > 7100059f7bfd > tests/long/fs/10.linux-boot/ref/arm/linux/realview-o3/stats.txt > 7100059f7bfd > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-atomic-dual/stats.txt > 7100059f7bfd > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-atomic/stats.txt > 7100059f7bfd > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-timing-dual/stats.txt > 7100059f7bfd > > tests/quick/fs/10.linux-boot/ref/alpha/linux/tsunami-simple-timing/stats.txt > 7100059f7bfd > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-atomic-dual/stats.txt > 7100059f7bfd > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-atomic/stats.txt > 7100059f7bfd > > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-timing-dual/stats.txt > 7100059f7bfd > tests/quick/fs/10.linux-boot/ref/arm/linux/realview-simple-timing/stats.txt > 7100059f7bfd > > tests/quick/fs/80.netperf-stream/ref/alpha/linux/twosys-tsunami-simple-atomic/config.ini > 7100059f7bfd > > tests/quick/fs/80.netperf-stream/ref/alpha/linux/twosys-tsunami-simple-atomic/stats.txt > 7100059f7bfd > > Diff: http://reviews.gem5.org/r/1183/diff/ > > > Testing > ------- > > All FS test passed except SPARC FS (FS files for SPARC no available) > All SE tests passed except eio tests. > > > Thanks, > > Jayneel Gandhi > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
