changeset 4fbbd05809d2 in /z/repo/gem5
details: http://repo.gem5.org/gem5?cmd=changeset;node=4fbbd05809d2
description:
Packet: Cleaning up packet command and attribute
This patch removes unused commands and attributes from the packet to
avoid any confusion. It is part of an effort to clear up how and where
different commands and attributes are used.
diffstat:
src/mem/packet.cc | 4 ++--
src/mem/packet.hh | 9 ++++++++-
2 files changed, 10 insertions(+), 3 deletions(-)
diffs (43 lines):
diff -r a20f46ccb9ce -r 4fbbd05809d2 src/mem/packet.cc
--- a/src/mem/packet.cc Wed May 23 09:16:39 2012 -0400
+++ b/src/mem/packet.cc Wed May 23 09:18:04 2012 -0400
@@ -98,11 +98,11 @@
/* HardPFResp */
{ SET4(IsRead, IsResponse, IsHWPrefetch, HasData),
InvalidCmd, "HardPFResp" },
- /* WriteInvalidateReq */
+ /* WriteInvalidateReq (currently unused, see packet.hh) */
{ SET6(IsWrite, NeedsExclusive, IsInvalidate,
IsRequest, HasData, NeedsResponse),
WriteInvalidateResp, "WriteInvalidateReq" },
- /* WriteInvalidateResp */
+ /* WriteInvalidateResp (currently unused, see packet.hh) */
{ SET3(IsWrite, NeedsExclusive, IsResponse),
InvalidCmd, "WriteInvalidateResp" },
/* UpgradeReq */
diff -r a20f46ccb9ce -r 4fbbd05809d2 src/mem/packet.hh
--- a/src/mem/packet.hh Wed May 23 09:16:39 2012 -0400
+++ b/src/mem/packet.hh Wed May 23 09:18:04 2012 -0400
@@ -91,6 +91,14 @@
HardPFReq,
SoftPFResp,
HardPFResp,
+ // WriteInvalidateReq transactions used to be generated by the
+ // DMA ports when writing full blocks to memory, however, it
+ // is not used anymore since we put the I/O cache in place to
+ // deal with partial block writes. Hence, WriteInvalidateReq
+ // and WriteInvalidateResp are currently unused. The
+ // implication is that the I/O cache does read-exclusive
+ // operations on every full-cache-block DMA, and ultimately
+ // this needs to be fixed.
WriteInvalidateReq,
WriteInvalidateResp,
UpgradeReq,
@@ -133,7 +141,6 @@
IsRead, //!< Data flows from responder to requester
IsWrite, //!< Data flows from requester to responder
IsUpgrade,
- IsPrefetch, //!< Not a demand access
IsInvalidate,
NeedsExclusive, //!< Requires exclusive copy to complete in-cache
IsRequest, //!< Issued by requester
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
