> On May 24, 2012, 7:44 a.m., Ali Saidi wrote: > > Seems fine, but I wonder about the new/free vs memcpy for the stl structs.
time build/ARM/gem5.opt -d build/ARM/tests/opt/long/fs/10.linux-boot/arm/linux/realview-o3 -re tests/run.py build/ARM/tests/opt/long/fs/10.linux-boot/arm/linux/realview-o3 Before this patch: 1177.904u 0.611s 19:41.18 99.7% 0+0k 0+0io 0pf+0w With this patch: 1190.752u 0.644s 19:52.32 99.9% 0+0k 0+0io 0pf+0w Note that this is a single run, so do not put too much emphasis on the 1% difference. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1214/#review2795 ----------------------------------------------------------- On May 23, 2012, 6:31 a.m., Andreas Hansson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1214/ > ----------------------------------------------------------- > > (Updated May 23, 2012, 6:31 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9020:a6bf1fdde3bb > --------------------------- > Bridge: Split deferred request, response and sender state > > This patch splits the PacketBuffer class into a RequestState and a > DeferredRequest and DeferredResponse. Only the requests need a > SenderState, and the deferred requests and responses only need an > associated point in time for the request and the response queue. > > Besides the cleaning up, the goal is to simplify the transition to a > new port handshake, and with these changes, the two packet queues are > starting to look very similar to the generic packet queue, but > currently they do a few unique things relating to the NACK and > counting of requests/responses that the packet queue cannot be > conveniently used. This will be addressed in a later patch. > > > Diffs > ----- > > src/mem/bridge.hh 4fbbd05809d2 > src/mem/bridge.cc 4fbbd05809d2 > > Diff: http://reviews.gem5.org/r/1214/diff/ > > > Testing > ------- > > util/regress all passing (disregarding t1000 and eio) > > > Thanks, > > Andreas Hansson > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
