----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1233/#review2833 -----------------------------------------------------------
The code change looks reasonable, but can you expand the commit message a bit? Looks like you not only got rid of the interface to get and set the TC, you got rid of the field that stores the TC altogether (i.e., you can't set it via the constructor now either). A sentence or two about why we don't need this anymore would help put this change in context. - Steve Reinhardt On May 28, 2012, 2:57 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1233/ > ----------------------------------------------------------- > > (Updated May 28, 2012, 2:57 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9033:e1a36e772fe1 > --------------------------- > Decoder: Remove the thread context getting/setting interface from the decoder. > > > Diffs > ----- > > src/arch/alpha/decoder.hh 1f2568933bc5 > src/arch/arm/decoder.hh 1f2568933bc5 > src/arch/arm/decoder.cc 1f2568933bc5 > src/arch/arm/isa.cc 1f2568933bc5 > src/arch/mips/decoder.hh 1f2568933bc5 > src/arch/power/decoder.hh 1f2568933bc5 > src/arch/sparc/decoder.hh 1f2568933bc5 > src/arch/sparc/isa.cc 1f2568933bc5 > src/arch/x86/decoder.hh 1f2568933bc5 > src/arch/x86/decoder.cc 1f2568933bc5 > src/cpu/checker/cpu_impl.hh 1f2568933bc5 > src/cpu/inorder/resources/fetch_unit.cc 1f2568933bc5 > src/cpu/legiontrace.cc 1f2568933bc5 > src/cpu/o3/fetch_impl.hh 1f2568933bc5 > src/cpu/simple/base.cc 1f2568933bc5 > src/cpu/simple_thread.cc 1f2568933bc5 > > Diff: http://reviews.gem5.org/r/1233/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
