> On May 28, 2012, 7:38 p.m., Steve Reinhardt wrote:
> > Looks OK to me. I can see where a common BaseBus class would clean up the
> > constructor situation a bit, and I think would allow some of the
> > NoncoherentBus-only bits like the ports to be more cleanly separated. If
> > you're up for it, Andreas, you might want to give it a try. It's not
> > unreasonable as it stands though.
> >
> > Comments below are orthogonal to the patch, just because I noticed this
> > code for the first time.
The split is done. The BaseBus resides in bus.{hh,cc}.
- Andreas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/1223/#review2843
-----------------------------------------------------------
On May 29, 2012, 11:03 a.m., Andreas Hansson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviews.gem5.org/r/1223/
> -----------------------------------------------------------
>
> (Updated May 29, 2012, 11:03 a.m.)
>
>
> Review request for Default.
>
>
> Description
> -------
>
> Changeset 9034:b5b92099f4c9
> ---------------------------
> Bus: Split the bus into a non-coherent and coherent bus
>
> This patch introduces a class hierarchy of buses, a non-coherent one,
> and a coherent one, splitting the existing bus functionality. By doing
> so it also enables further specialisation of the two types of buses.
>
> A non-coherent bus connects a number of non-snooping masters and
> slaves, and routes the request and response packets based on the
> address. The request packets issued by the master connected to a
> non-coherent bus could still snoop in caches attached to a coherent
> bus, as is the case with the I/O bus and memory bus in most system
> configurations. No snoops will, however, reach any master on the
> non-coherent bus itself. The non-coherent bus can be used as a
> template for modelling PCI, PCIe, and non-coherent AMBA and OCP buses,
> and is typically used for the I/O buses.
>
> A coherent bus connects a number of (potentially) snooping masters and
> slaves, and routes the request and response packets based on the
> address, and also forwards all requests to the snoopers and deals with
> the snoop responses. The coherent bus can be used as a template for
> modelling QPI, HyperTransport, ACE and coherent OCP buses, and is
> typically used for the L1-to-L2 buses and as the main system
> interconnect.
>
> The configuration scripts are updated to use a NoncoherentBus for all
> peripheral and I/O buses.
>
> A bit of minor tidying up has also been done.
>
>
> Diffs
> -----
>
> configs/common/CacheConfig.py f92783bcfd25
> configs/common/FSConfig.py f92783bcfd25
> configs/example/memtest.py f92783bcfd25
> configs/example/se.py f92783bcfd25
> configs/splash2/cluster.py f92783bcfd25
> configs/splash2/run.py f92783bcfd25
> src/cpu/BaseCPU.py f92783bcfd25
> src/mem/Bus.py f92783bcfd25
> src/mem/SConscript f92783bcfd25
> src/mem/bus.hh f92783bcfd25
> src/mem/bus.cc f92783bcfd25
> src/mem/coherent_bus.hh PRE-CREATION
> src/mem/coherent_bus.cc PRE-CREATION
> src/mem/noncoherent_bus.hh PRE-CREATION
> src/mem/noncoherent_bus.cc PRE-CREATION
> tests/configs/inorder-timing.py f92783bcfd25
> tests/configs/memtest.py f92783bcfd25
> tests/configs/o3-timing-checker.py f92783bcfd25
> tests/configs/o3-timing-mp-ruby.py f92783bcfd25
> tests/configs/o3-timing-mp.py f92783bcfd25
> tests/configs/o3-timing-ruby.py f92783bcfd25
> tests/configs/o3-timing.py f92783bcfd25
> tests/configs/pc-o3-timing.py f92783bcfd25
> tests/configs/pc-simple-atomic.py f92783bcfd25
> tests/configs/pc-simple-timing.py f92783bcfd25
> tests/configs/realview-o3-checker.py f92783bcfd25
> tests/configs/realview-o3-dual.py f92783bcfd25
> tests/configs/realview-o3.py f92783bcfd25
> tests/configs/realview-simple-atomic-dual.py f92783bcfd25
> tests/configs/realview-simple-atomic.py f92783bcfd25
> tests/configs/realview-simple-timing-dual.py f92783bcfd25
> tests/configs/realview-simple-timing.py f92783bcfd25
> tests/configs/simple-atomic-dummychecker.py f92783bcfd25
> tests/configs/simple-atomic-mp-ruby.py f92783bcfd25
> tests/configs/simple-atomic-mp.py f92783bcfd25
> tests/configs/simple-atomic.py f92783bcfd25
> tests/configs/simple-timing-mp.py f92783bcfd25
> tests/configs/simple-timing.py f92783bcfd25
> tests/configs/tsunami-inorder.py f92783bcfd25
> tests/configs/tsunami-o3-dual.py f92783bcfd25
> tests/configs/tsunami-o3.py f92783bcfd25
> tests/configs/tsunami-simple-atomic-dual.py f92783bcfd25
> tests/configs/tsunami-simple-atomic.py f92783bcfd25
> tests/configs/tsunami-simple-timing-dual.py f92783bcfd25
> tests/configs/tsunami-simple-timing.py f92783bcfd25
>
> Diff: http://reviews.gem5.org/r/1223/diff/
>
>
> Testing
> -------
>
> util/regress all passing (disregarding t1000 and eio)
>
>
> Thanks,
>
> Andreas Hansson
>
>
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
