----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1248/#review2887 -----------------------------------------------------------
Ship it! Ship It! - Steve Reinhardt On June 3, 2012, 2:02 a.m., Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1248/ > ----------------------------------------------------------- > > (Updated June 3, 2012, 2:02 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9037:8a7aa00b20a4 > --------------------------- > X86: Ensure that the decoder's internal ExtMachInst is completely initialized. > > There are some bits of some fields of the ExtMachInst which are not actually > used for anything but are included in the hash of an ExtMachInst for > simplicity and efficiency. This change makes sure the decoder's internal > working ExtMachInst is completely initialized, even these unused bits, so that > there isn't any nondeterministic behavior, no valgrind messages about > uninitialized variables, and no potential false misses/redundant entries in > the decode cache. > > > Diffs > ----- > > src/arch/x86/decoder.hh 6385cf85bf12 > > Diff: http://reviews.gem5.org/r/1248/diff/ > > > Testing > ------- > > > Thanks, > > Gabe Black > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
