> On June 20, 2012, 10:04 p.m., Brad Beckmann wrote: > > src/mem/ruby/slicc_interface/RubySlicc_Util.hh, line 81 > > <http://reviews.gem5.org/r/1270/diff/1/?file=27365#file27365line81> > > > > Some of these functions are used by protocols not checked into the main > > tree. Please do not delete them.
Can you be specific on what is required and what's not? - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1270/#review2980 ----------------------------------------------------------- On June 15, 2012, 12:52 a.m., Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1270/ > ----------------------------------------------------------- > > (Updated June 15, 2012, 12:52 a.m.) > > > Review request for Default. > > > Description > ------- > > Changeset 9067:a7cd5e027d74 > --------------------------- > Ruby: remove some unused stuff from SLICC files > > > Diffs > ----- > > src/mem/protocol/RubySlicc_Defines.sm 35ac3a6f8ee0 > src/mem/protocol/RubySlicc_Exports.sm 35ac3a6f8ee0 > src/mem/protocol/RubySlicc_MemControl.sm 35ac3a6f8ee0 > src/mem/protocol/RubySlicc_Profiler.sm 35ac3a6f8ee0 > src/mem/protocol/RubySlicc_Util.sm 35ac3a6f8ee0 > src/mem/ruby/network/Topology.cc 35ac3a6f8ee0 > src/mem/ruby/network/simple/SimpleNetwork.cc 35ac3a6f8ee0 > src/mem/ruby/slicc_interface/RubyRequest.hh 35ac3a6f8ee0 > src/mem/ruby/slicc_interface/RubySlicc_Profiler_interface.hh 35ac3a6f8ee0 > src/mem/ruby/slicc_interface/RubySlicc_Util.hh 35ac3a6f8ee0 > > Diff: http://reviews.gem5.org/r/1270/diff/ > > > Testing > ------- > > > Thanks, > > Nilay Vaish > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
