----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/1278/ -----------------------------------------------------------
Review request for Default. Description ------- Changeset 9073:649586dc385a --------------------------- gcc: Fix memset warnings concerning constant zero length This patch solves two link-time warnings that are raised by gcc 4.7.1 after performing what seems to be an astonishing amount of unrolling and inlining as part of Link Time Optimization (it takes almost 3 hours for ARM and uses a good 4+ GByte of memory). As the linking is about to finish, _format_string in cprintf and memsetBlob in the PortProxy are both causing a number of warnings: "call to '__warn_memset_zero_len' declared with attribute warning: memset used with constant zero length parameter;". It is not clear from the code why this would ever happen unless gcc moves the block of code. In any case, the changes make these warning disappear. Diffs ----- src/base/cprintf_formats.hh d8e5ca139d7c src/mem/port_proxy.cc d8e5ca139d7c Diff: http://reviews.gem5.org/r/1278/diff/ Testing ------- util/regress all passing (disregarding t1000 and eio) compiled with gcc 4.3 - 4.7 and clang 2.9 - 3.1 Thanks, Andreas Hansson _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
