If this is okay for now, can someone please push it? I think the stats in the regression tests might need to be updated as well. Is this something I need to do? Sorry, I'm a little new to this whole process.
Thanks, Lena 2012/6/28 Andreas Hansson <[email protected]> > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/1275/ > > Ship it! > > Ship It! > > > - Andreas > > On June 18th, 2012, 4:17 p.m., Lena Olson wrote: > Review request for Default. > By Lena Olson. > > *Updated June 18, 2012, 4:17 p.m.* > Description > > Changeset 9071:7526dad15b35 > --------------------------- > Cache: Fix the LRU policy for classic memory hierarchy > > The LRU policy always evicted the least recently touched way, even if it > contained valid data and another way was invalid, as can happen if a block has > been invalidated by coherance. This can result in caches never warming up > even > though they are replacing blocks. This modifies the LRU policy to move blocks > to LRU position on invalidation. > > Diffs > > - src/mem/cache/tags/cacheset.hh > (fa77985a87c6ff77284ed9bdd4ae304b2e373666) > - src/mem/cache/tags/cacheset.cc > (fa77985a87c6ff77284ed9bdd4ae304b2e373666) > - src/mem/cache/tags/lru.cc (fa77985a87c6ff77284ed9bdd4ae304b2e373666) > > View Diff <http://reviews.gem5.org/r/1275/diff/> > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
